linux-kernel - Re: [PATCH] irqchip/armada-370-xp: Enable MSI affinity configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 23 Apr 2022 18:21:53 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Nathan Rossi <nathan@...hanrossi.com>
Cc:     Marc Zyngier <maz@...nel.org>,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        Nathan Rossi <nathan.rossi@...i.com>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH] irqchip/armada-370-xp: Enable MSI affinity configuration

On Fri, Apr 22, 2022 at 10:58:23PM +1000, Nathan Rossi wrote:
> On Fri, 22 Apr 2022 at 22:19, Andrew Lunn <andrew@...n.ch> wrote:
> >
> > > If you have a PCIe device that you can use with the 370 rd.
> >
> > Sorry, nothing on its bus.
> >
> > The only device i have which might make sense testing is a
> > WRT1900ac. That has an Armada XP dual core. I could try building a UP
> > kernel for it, but i guess you have tried that already with your
> > machine in order to test a UP setup?
> 
> I have tested with SMP=n on a Armada 385 without any issues. So no
> need to do that on the Armada XP.
> 
> There is still value in testing on the WRT1900ac device since so far I
> have only tested on a Armada 385. The Armada XP does have
> registers/etc. of the MPIC very similar to the 370, compared to the
> 385 having some significant differences. So if it is not too
> problematic to test on (it appears to have its wifi attached via
> PCIe?) please do.

Hi Nathan

Turns out the WiFi drivers are in a sorry state. There is no mainline
driver. There is an OpenWRT driver, but it has not been updated for a
few years, tries to use get_fs() set_fs() pci_map_single() etc.

I've mostly used this platform for Ethernet switch development, so
i've never tried the WiFi before. I had no idea it was so broken...

So sorry, i cannot test this.

     Andrew