linux-kernel - Re: [PATCH] bus: sunxi-rsb: Fix the return value of sunxi_rsb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff0ae741-efc4-ba6f-d869-4cb8fb7149ad@sholland.org>
Date:   Sat, 23 Apr 2022 14:39:45 -0500
From:   Samuel Holland <samuel@...lland.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Chen-Yu Tsai <wens@...e.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev
Subject: Re: [PATCH] bus: sunxi-rsb: Fix the return value of
 sunxi_rsb_device_create()

On 4/21/22 9:35 AM, Christophe JAILLET wrote:
> This code is really spurious.
> It always returns an ERR_PTR, even when err is known to be 0 and calls
> put_device() after a successful device_register() call.
> 
> It is likely that the return statement in the normal path is missing.
> Add 'return rdev;' to fix it.

Thanks for the patch. This definitely looks to be the case.

> Fixes: d787dcdb9c8f ("bus: sunxi-rsb: Add driver for Allwinner Reduced Serial Bus")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Samuel Holland <samuel@...lland.org>
Tested-by: Samuel Holland <samuel@...lland.org>