linux-kernel - Re: Re: [PATCH] bus: sunxi-rsb: Fix the return value of sunxi_rsb_device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2699804.BEx9A2HvPv@kista>
Date:   Mon, 25 Apr 2022 19:31:21 +0200
From:   Jernej Škrabec <jernej.skrabec@...il.com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Chen-Yu Tsai <wens@...e.org>, Mark Brown <broonie@...nel.org>,
        Maxime Ripard <mripard@...nel.org>,
        Arnd Bergmann <arnd@...db.de>, Olof Johansson <olof@...om.net>,
        Samuel Holland <samuel@...lland.org>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, linux-sunxi@...ts.linux.dev
Subject: Re: Re: [PATCH] bus: sunxi-rsb: Fix the return value of sunxi_rsb_device_create()

Dne sobota, 23. april 2022 ob 21:39:45 CEST je Samuel Holland napisal(a):
> On 4/21/22 9:35 AM, Christophe JAILLET wrote:
> > This code is really spurious.
> > It always returns an ERR_PTR, even when err is known to be 0 and calls
> > put_device() after a successful device_register() call.
> > 
> > It is likely that the return statement in the normal path is missing.
> > Add 'return rdev;' to fix it.
> 
> Thanks for the patch. This definitely looks to be the case.
> 
> > Fixes: d787dcdb9c8f ("bus: sunxi-rsb: Add driver for Allwinner Reduced 
Serial Bus")
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> 
> Reviewed-by: Samuel Holland <samuel@...lland.org>
> Tested-by: Samuel Holland <samuel@...lland.org>
> 

Applied to sunxi/fixes-for-5.18, thanks!

Best regards,
Jernej