linux-kernel - Re: [PATCH] jfs: remove unused pointer tblk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <64ef5a2f-4421-3509-4919-b9c2173a5f17@oracle.com>
Date:   Mon, 25 Apr 2022 12:08:45 -0500
From:   Dave Kleikamp <dave.kleikamp@...cle.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Colin Ian King <colin.i.king@...il.com>
Cc:     jfs-discussion@...ts.sourceforge.net,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] jfs: remove unused pointer tblk

On 4/25/22 9:48AM, Dan Carpenter wrote:
> On Sun, Apr 24, 2022 at 05:13:30PM +0100, Colin Ian King wrote:
>> The pointer tlbk is not used, it is redundant and can be removed.
>> Cleans up cppcheck warning:
>>
>> linux/fs/jfs/jfs_xtree.c:2551:17: style: Unused variable: tblk [unusedVariable]
>>
>> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
>> ---
>>   fs/jfs/jfs_xtree.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/fs/jfs/jfs_xtree.c b/fs/jfs/jfs_xtree.c
>> index 3148e9b35f3b..d29979d0a6aa 100644
>> --- a/fs/jfs/jfs_xtree.c
>> +++ b/fs/jfs/jfs_xtree.c
>> @@ -2548,7 +2548,6 @@ xtRelocate(tid_t tid, struct inode * ip, xad_t * oxad,	/* old XAD */
>>   	   int xtype)
>>   {				/* extent type: XTPAGE or DATAEXT */
>>   	int rc = 0;
>> -	struct tblock *tblk;
> 
> This would have caused a build error if it weren't ifdeffed out.
> 
> #ifdef _STILL_TO_PORT
> 
> JFS is an IBM filesystem from OS/2.  Apparently, this stuff never got
> ported?  Probably we could just delete the dead code.

Yeah. Once, long ago, I had dreams of enhancing JFS with shiny new 
function like defragmentation. I think it's safe to say that isn't going 
to happen.

Shaggy

> 
> regards,
> dan carpenter
>