linux-kernel - Re: [PATCH] device-dax: use kobj_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 26 Apr 2022 02:25:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     cgel.zte@...il.com, dan.j.williams@...el.com
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        vishal.l.verma@...el.com, dave.jiang@...el.com,
        nvdimm@...ts.linux.dev, linux-kernel@...r.kernel.org,
        Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] device-dax: use kobj_to_dev()

Hi,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[also build test ERROR on v5.18-rc4 next-20220422]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/cgel-zte-gmail-com/device-dax-use-kobj_to_dev/20220425-185400
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git af2d861d4cd2a4da5137f795ee3509e6f944a25b
config: hexagon-randconfig-r041-20220425 (https://download.01.org/0day-ci/archive/20220426/202204260238.kDqgLOsU-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 1cddcfdc3c683b393df1a5c9063252eb60e52818)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/83eff180ded41da8e042373de81fa823835a1be0
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review cgel-zte-gmail-com/device-dax-use-kobj_to_dev/20220425-185400
        git checkout 83eff180ded41da8e042373de81fa823835a1be0
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

>> drivers/dax/bus.c:515:40: error: expected ';' at end of declaration
           struct device *dev = kobj_to_dev(kobj)
                                                 ^
                                                 ;
   1 error generated.


vim +515 drivers/dax/bus.c

   511	
   512	static umode_t dax_region_visible(struct kobject *kobj, struct attribute *a,
   513			int n)
   514	{
 > 515		struct device *dev = kobj_to_dev(kobj)
   516		struct dax_region *dax_region = dev_get_drvdata(dev);
   517	
   518		if (is_static(dax_region))
   519			if (a == &dev_attr_available_size.attr
   520					|| a == &dev_attr_create.attr
   521					|| a == &dev_attr_seed.attr
   522					|| a == &dev_attr_delete.attr)
   523				return 0;
   524		return a->mode;
   525	}
   526	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp