linux-kernel - Re: [PATCH] arm64: dts: qcom: sc7280: eDP for herobrine boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAE-0n52OdZLLRKot+eu4YN9Tu3p4Lau0NR0vTbwfGiHhBCmZQw@mail.gmail.com>
Date:   Mon, 25 Apr 2022 16:31:53 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Douglas Anderson <dianders@...omium.org>
Cc:     Kuogee Hsieh <quic_khsieh@...cinc.com>,
        Abhinav Kumar <quic_abhinavk@...cinc.com>,
        Matthias Kaehlcke <mka@...omium.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Rob Clark <robdclark@...omium.org>, quic_kalyant@...cinc.com,
        Sankeerth Billakanti <quic_sbillaka@...cinc.com>,
        linux-arm-msm@...r.kernel.org, Andy Gross <agross@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: qcom: sc7280: eDP for herobrine boards

Quoting Douglas Anderson (2022-04-25 15:36:55)
> This change adds in eDP for herobrine boards, splitting up amongst the

Imperative mood please.

 $ git grep "This patch" -- Documentation/process/

Add eDP support to herobrine boards, splitting up ..

> different files as makes sense. Rationale for the current split of
> things:
> * The eDP connector itself is on qcard. However, not all devices with
>   a qcard will use an eDP panel. Some might use MIPI and, presumably,
>   someone could build a device with qcard that had no display at all.
> * The qcard provides a PWM for backlight that goes to the eDP
>   connector. This PWM is also is provided to the board and it's

s/also is/also/

>   expected that it would be used as the backlight PWM even for
>   herobrine devices with MIPI displays.
[...]
> diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> index d58045dd7334..769d440d1917 100644
> --- a/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine.dtsi
> @@ -367,6 +367,14 @@ &vreg_l2c_1p8 {
>
>  /* ADDITIONS TO NODES DEFINED IN PARENT DEVICE TREE FILES */
>
> +&edp_panel {
> +       /*
> +        * Now that we've defined which power supply we give to qcard for
> +        * eDP we can hook it up in the panel node.

I don't understand this comment. "Now" triggers my brain to think that
something happened when this line was written. But maybe it means
something was done earlier in the file? When is "now"? I don't really
know. Maybe this is clearer:

	/* Our board provides power to the qcard for the eDP panel. */

> +        */
> +       power-supply = <&vreg_edp_3p3>;
> +};
> +
>  ap_sar_sensor_i2c: &i2c1 {
>         clock-frequency = <400000>;
>         status = "disabled";
> @@ -429,6 +445,20 @@ &pcie1 {
>         vddpe-3v3-supply = <&pp3300_ssd>;
>  };
>
> +&pm8350c_pwm {
> +       status = "okay";
> +};
> +
> +&pm8350c_pwm_backlight {
> +       status = "okay";
> +
> +       /*
> +        * Now that we've defined which power supply we give to qcard for
> +        * backlight we can hook it up in the panel node.

Same comment.

> +        */
> +       power-supply = <&vreg_edp_bl>;
> +};
> +