linux-kernel - Re: [PATCH] mm/memcg: minor cleanup in non-memcg_kmem version of mem_cgroup_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YmZPqAOLO7XkBsW8@dhcp22.suse.cz>
Date:   Mon, 25 Apr 2022 09:37:12 +0200
From:   Michal Hocko <mhocko@...e.com>
To:     Vasily Averin <vvs@...nvz.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Shakeel Butt <shakeelb@...gle.com>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/memcg: minor cleanup in non-memcg_kmem version of
 mem_cgroup_from_obj()

On Sat 23-04-22 05:23:03, Vasily Averin wrote:
> Replace leading spaces by tab:
>  WARNING: please, no spaces at the start of a line
>  #X: FILE: include/linux/memcontrol.h:1480:
>  +       return NULL;$
> 
> Fixes: commit 8380ce479010 ("mm: fork: fix kernel_stack memcg stats for various stack implementations")

Please drop the Fixes tag. The tag is supposed to point to a functional
breakage and this is purely a style fix.

> Signed-off-by: Vasily Averin <vvs@...nvz.org>

Acked-by: Michal Hocko <mhocko@...e.com>

> ---
>  include/linux/memcontrol.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/memcontrol.h b/include/linux/memcontrol.h
> index a68dce3873fc..294515d06dbe 100644
> --- a/include/linux/memcontrol.h
> +++ b/include/linux/memcontrol.h
> @@ -1753,7 +1753,7 @@ static inline int memcg_kmem_id(struct mem_cgroup *memcg)
>  
>  static inline struct mem_cgroup *mem_cgroup_from_obj(void *p)
>  {
> -       return NULL;
> +	return NULL;
>  }
>  
>  #endif /* CONFIG_MEMCG_KMEM */
> -- 
> 2.25.1

-- 
Michal Hocko
SUSE Labs