linux-kernel - Re: [PATCH] mm/memcg: minor cleanup in non-memcg_kmem version of mem_cgroup_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <791eca4c-8ffe-7ddf-cc48-7c3a29b858d2@openvz.org>
Date:   Mon, 25 Apr 2022 11:40:21 +0300
From:   Vasily Averin <vvs@...nvz.org>
To:     Michal Hocko <mhocko@...e.com>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        Shakeel Butt <shakeelb@...gle.com>,
        Roman Gushchin <roman.gushchin@...ux.dev>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/memcg: minor cleanup in non-memcg_kmem version of
 mem_cgroup_from_obj()

On 4/25/22 10:37, Michal Hocko wrote:
> On Sat 23-04-22 05:23:03, Vasily Averin wrote:
>> Replace leading spaces by tab:
>>  WARNING: please, no spaces at the start of a line
>>  #X: FILE: include/linux/memcontrol.h:1480:
>>  +       return NULL;$
>>
>> Fixes: commit 8380ce479010 ("mm: fork: fix kernel_stack memcg stats for various stack implementations")
> 
> Please drop the Fixes tag. The tag is supposed to point to a functional
> breakage and this is purely a style fix.
> 
>> Signed-off-by: Vasily Averin <vvs@...nvz.org>
> 
> Acked-by: Michal Hocko <mhocko@...e.com>

Andrew Morton suggested do not create separate patch for this change,
So I'm going to combine it with my next patch, which adds a few lines below.
Even if it will not be approved -- it isn't a big problem, someone will fix it later.