linux-kernel - Re: [RESEND][PATCH] qedf: remove an unneeded NULL check on list iterator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <yq1o80ot3yd.fsf@ca-mkp.ca.oracle.com>
Date:   Tue, 26 Apr 2022 08:38:29 -0400
From:   "Martin K. Petersen" <martin.petersen@...cle.com>
To:     Xiaomeng Tong <xiam0nd.tong@...il.com>
Cc:     skashyap@...vell.com, jhasan@...vell.com,
        GR-QLogic-Storage-Upstream@...vell.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [RESEND][PATCH] qedf: remove an unneeded NULL check on list
 iterator


Xiaomeng,

> The list iterator 'fcport' is always non-NULL so it doesn't need to be
> checked. Thus just remove the unnecessary NULL check. Also remove the
> unnecessary initializer because the list iterator is always initialized.
> And adjust the position of blank lines.

Applied to 5.19/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering