linux-kernel - Re: [PATCH] drm/nouveau/kms/gv100: use static for gv100_disp_core_mthd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a46595078332c8e0ad801f3f8eb03ca9c11db8dc.camel@redhat.com>
Date:   Tue, 26 Apr 2022 13:26:24 -0400
From:   Lyude Paul <lyude@...hat.com>
To:     Tom Rix <trix@...hat.com>, bskeggs@...hat.com, kherbst@...hat.com,
        airlied@...ux.ie, daniel@...ll.ch
Cc:     dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/nouveau/kms/gv100: use static for
 gv100_disp_core_mthd_[base|sor]

Reviewed-by: Lyude Paul <lyude@...hat.com>

Will push to the appropriate branch in a bit

On Fri, 2022-04-22 at 14:51 -0400, Tom Rix wrote:
> Sparse reports these issues
> coregv100.c:27:1: warning: symbol 'gv100_disp_core_mthd_base' was not
> declared. Should it be static?
> coregv100.c:43:1: warning: symbol 'gv100_disp_core_mthd_sor' was not
> declared. Should it be static?
> 
> These variables are only used in coregv100.c.  Single file use
> variables should be static, so add static to their storage-class specifier.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c
> index 448a515057c7..1d333c484a49 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/coregv100.c
> @@ -23,7 +23,7 @@
>  
>  #include <subdev/timer.h>
>  
> -const struct nv50_disp_mthd_list
> +static const struct nv50_disp_mthd_list
>  gv100_disp_core_mthd_base = {
>         .mthd = 0x0000,
>         .addr = 0x000000,
> @@ -39,7 +39,7 @@ gv100_disp_core_mthd_base = {
>         }
>  };
>  
> -const struct nv50_disp_mthd_list
> +static const struct nv50_disp_mthd_list
>  gv100_disp_core_mthd_sor = {
>         .mthd = 0x0020,
>         .addr = 0x000020,

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat