linux-kernel - Re: [PATCH] drm/nouveau/disp/gv100: make gv100_disp_wndw and gv100_disp_wndw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7f2ac9892b93d452a728d07a49a4446b81ce76be.camel@redhat.com>
Date:   Tue, 26 Apr 2022 13:46:52 -0400
From:   Lyude Paul <lyude@...hat.com>
To:     Tom Rix <trix@...hat.com>, bskeggs@...hat.com, kherbst@...hat.com,
        airlied@...ux.ie, daniel@...ll.ch
Cc:     dri-devel@...ts.freedesktop.org, nouveau@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/nouveau/disp/gv100: make gv100_disp_wndw and
 gv100_disp_wndw_mthd static

Reviewed-by: Lyude Paul <lyude@...hat.com>

Will push upstream in a moment

On Mon, 2022-04-25 at 09:13 -0400, Tom Rix wrote:
> Sparse reports these issues
> wndwgv100.c:120:1: warning: symbol 'gv100_disp_wndw_mthd' was not declared.
> Should it be static?
> wndwgv100.c:140:1: warning: symbol 'gv100_disp_wndw' was not declared.
> Should it be static?
> 
> These variable are only used in wndwgv100.c.  Single file variables should
> be static.
> So use static as their storage-class specifiers.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c
> b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c
> index 5d3b641dbb14..e635247d794f 100644
> --- a/drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c
> +++ b/drivers/gpu/drm/nouveau/nvkm/engine/disp/wndwgv100.c
> @@ -116,7 +116,7 @@ gv100_disp_wndw_mthd_base = {
>         }
>  };
>  
> -const struct nv50_disp_chan_mthd
> +static const struct nv50_disp_chan_mthd
>  gv100_disp_wndw_mthd = {
>         .name = "Window",
>         .addr = 0x001000,
> @@ -136,7 +136,7 @@ gv100_disp_wndw_intr(struct nv50_disp_chan *chan, bool
> en)
>         nvkm_mask(device, 0x611da4, mask, data);
>  }
>  
> -const struct nv50_disp_chan_func
> +static const struct nv50_disp_chan_func
>  gv100_disp_wndw = {
>         .init = gv100_disp_dmac_init,
>         .fini = gv100_disp_dmac_fini,

-- 
Cheers,
 Lyude Paul (she/her)
 Software Engineer at Red Hat