linux-kernel - RE: [PATCH net-next v9 2/2] net: ethernet: Add driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3b9a6b2ce9e84b82963ad9a46b871b35@sphcmbx02.sunplus.com.tw>
Date:   Tue, 26 Apr 2022 01:37:42 +0000
From:   Wells Lu 呂芳騰 <wells.lu@...plus.com>
To:     Stephen Hemminger <stephen@...workplumber.org>,
        Wells Lu <wellslutw@...il.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "p.zabel@...gutronix.de" <p.zabel@...gutronix.de>,
        "pabeni@...hat.com" <pabeni@...hat.com>,
        "krzk+dt@...nel.org" <krzk+dt@...nel.org>,
        "roopa@...dia.com" <roopa@...dia.com>,
        "andrew@...n.ch" <andrew@...n.ch>,
        "edumazet@...gle.com" <edumazet@...gle.com>
Subject: RE: [PATCH net-next v9 2/2] net: ethernet: Add driver for Sunplus
 SP7021

Hi Stephen,


> > diff --git a/drivers/net/ethernet/sunplus/spl2sw_driver.h
> > b/drivers/net/ethernet/sunplus/spl2sw_driver.h
> > new file mode 100644
> > index 000000000..5f177b3af
> > --- /dev/null
> > +++ b/drivers/net/ethernet/sunplus/spl2sw_driver.h
> > @@ -0,0 +1,12 @@
> > +/* SPDX-License-Identifier: GPL-2.0 */
> > +/* Copyright Sunplus Technology Co., Ltd.
> > + *       All rights reserved.
> > + */
> > +
> > +#ifndef __SPL2SW_DRIVER_H__
> > +#define __SPL2SW_DRIVER_H__
> > +
> > +#define SPL2SW_RX_NAPI_WEIGHT	16
> > +#define SPL2SW_TX_NAPI_WEIGHT	16
> 
> Why define your own? there is NAPI_POLL_WEIGHT already defined in netdevice.h

I didn't know there is NAPI_POLL_WEIGHT defined in netdevice.h.
I'll remove my own define and use it next patch.

Thank you for your review.


Best regards,
Wells