| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <5752f130-c040-6156-44dc-497011f2a78e@quicinc.com>
Date: Wed, 27 Apr 2022 22:27:35 +0800
From: Jinlong Mao <quic_jinlmao@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@...ainline.org>,
Mathieu Poirier <mathieu.poirier@...aro.org>,
Suzuki K Poulose <suzuki.poulose@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>
CC: Mike Leach <mike.leach@...aro.org>, Leo Yan <leo.yan@...aro.org>,
"Greg Kroah-Hartman" <gregkh@...uxfoundation.org>,
<coresight@...ts.linaro.org>,
<linux-arm-kernel@...ts.infradead.org>,
<linux-kernel@...r.kernel.org>,
Tingwei Zhang <quic_tingweiz@...cinc.com>,
Yuanfang Zhang <quic_yuanfang@...cinc.com>,
Tao Zhang <quic_taozha@...cinc.com>,
Trilok Soni <quic_tsoni@...cinc.com>,
Hao Zhang <quic_hazha@...cinc.com>,
<linux-arm-msm@...r.kernel.org>,
Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [PATCH v6 10/10] ARM: dts: msm: Add tpdm mm/prng for sm8250
Thank you Konrad for the review.
On 4/26/2022 7:49 PM, Konrad Dybcio wrote:
>
> On 25/04/2022 06:03, Mao Jinlong wrote:
>> Add tpdm mm and tpdm prng for sm8250.
>>
>> +---------------+ +-------------+
>> | tpdm@...8000 | |tpdm@...C000 |
>> +-------|-------+ +------|------+
>> | |
>> +-------|-------+ |
>> | funnel@...b000| |
>> +-------|-------+ |
>> | |
>> +-------|-------+ |
>> |funnel@...d000 | |
>> +-------|-------+ |
>> | |
>> | +---------------+ |
>> +----- tpda@...4000 -----------+
>> +-------|-------+
>> |
>> +-------|-------+
>> |funnel@...5000 |
>> +---------------+
>>
>> Signed-off-by: Mao Jinlong <quic_jinlmao@...cinc.com>
>> ---
>> arch/arm64/boot/dts/qcom/sm8250.dtsi | 170 +++++++++++++++++++++++++++
>> 1 file changed, 170 insertions(+)
>
> Hi,
>
>
> some of the previous comments (uppercase hex instead of lowercase and
> wrong commit title) still haven't been addressed.
I will double check and address your comments.
Thanks
Jinlong Mao
>
>
> Konrad
>
>> diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> index 53ab2b457a2f..ce558a2639e7 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
>> @@ -4703,6 +4703,73 @@
>> };
>> };
>> + tpda@...4000 {
>> + compatible = "arm,primecell";
>> + reg = <0 0x06004000 0 0x1000>;
>> + reg-names = "tpda-base";
>> +
>> + clocks = <&aoss_qmp>;
>> + clock-names = "apb_pclk";
>> +
>> + out-ports {
>> + port {
>> + reg = <0>;
>> + tpda_out_funnel_qatb: endpoint {
>> + remote-endpoint = <&funnel_qatb_in_tpda>;
>> + };
>> + };
>> + };
>> +
>> + in-ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@9 {
>> + reg = <9>;
>> + tpda_9_in_tpdm_mm: endpoint {
>> + remote-endpoint = <&tpdm_mm_out_tpda9>;
>> + };
>> + };
>> +
>> + port@23 {
>> + reg = <23>;
>> + tpda_23_in_tpdm_prng: endpoint {
>> + remote-endpoint = <&tpdm_prng_out_tpda_23>;
>> + };
>> + };
>> + };
>> + };
>> +
>> + funnel@...5000 {
>> + compatible = "arm,primecell";
>> +
>> + reg = <0 0x06005000 0 0x1000>;
>> + reg-names = "funnel-base";
>> +
>> + clocks = <&aoss_qmp>;
>> + clock-names = "apb_pclk";
>> +
>> + out-ports {
>> + port {
>> + funnel_qatb_out_funnel_in0: endpoint {
>> + remote-endpoint = <&funnel_in0_in_funnel_qatb>;
>> + };
>> + };
>> + };
>> +
>> + in-ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@0 {
>> + reg = <0>;
>> + funnel_qatb_in_tpda: endpoint {
>> + remote-endpoint = <&tpda_out_funnel_qatb>;
>> + };
>> + };
>> + };
>> + };
>> +
>> funnel@...1000 {
>> compatible = "arm,coresight-dynamic-funnel",
>> "arm,primecell";
>> reg = <0 0x06041000 0 0x1000>;
>> @@ -4722,6 +4789,13 @@
>> #address-cells = <1>;
>> #size-cells = <0>;
>> + port@6 {
>> + reg = <6>;
>> + funnel_in0_in_funnel_qatb: endpoint {
>> + remote-endpoint =
>> <&funnel_qatb_out_funnel_in0>;
>> + };
>> + };
>> +
>> port@7 {
>> reg = <7>;
>> funnel0_in7: endpoint {
>> @@ -4836,6 +4910,23 @@
>> };
>> };
>> + tpdm@...C000 {
>> + compatible = "arm,primecell";
>> + reg = <0 0x0684C000 0 0x1000>;
>> + reg-names = "tpdm-base";
>> +
>> + clocks = <&aoss_qmp>;
>> + clock-names = "apb_pclk";
>> +
>> + out-ports {
>> + port {
>> + tpdm_prng_out_tpda_23: endpoint {
>> + remote-endpoint = <&tpda_23_in_tpdm_prng>;
>> + };
>> + };
>> + };
>> + };
>> +
>> funnel@...4000 {
>> compatible = "arm,coresight-dynamic-funnel",
>> "arm,primecell";
>> arm,primecell-periphid = <0x000bb908>;
>> @@ -4920,6 +5011,85 @@
>> };
>> };
>> + tpdm@...8000 {
>> + compatible = "arm,primecell";
>> + reg = <0 0x06c08000 0 0x1000>;
>> + reg-names = "tpdm-base";
>> +
>> + clocks = <&aoss_qmp>;
>> + clock-names = "apb_pclk";
>> +
>> + out-ports {
>> + port {
>> + tpdm_mm_out_funnel_dl_mm: endpoint {
>> + remote-endpoint = <&funnel_dl_mm_in_tpdm_mm>;
>> + };
>> + };
>> + };
>> + };
>> +
>> + funnel@...b000 {
>> + compatible = "arm,coresight-dynamic-funnel",
>> "arm,primecell";
>> +
>> + reg = <0 0x06c0b000 0 0x1000>;
>> + reg-names = "funnel-base";
>> +
>> + clocks = <&aoss_qmp>;
>> + clock-names = "apb_pclk";
>> +
>> + out-ports {
>> + port {
>> + funnel_dl_mm_out_funnel_dl_center: endpoint {
>> + remote-endpoint =
>> <&funnel_dl_center_in_funnel_dl_mm>;
>> + };
>> + };
>> + };
>> +
>> + in-ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@3 {
>> + reg = <3>;
>> + funnel_dl_mm_in_tpdm_mm: endpoint {
>> + remote-endpoint = <&tpdm_mm_out_funnel_dl_mm>;
>> + };
>> + };
>> + };
>> + };
>> +
>> + funnel@...d000 {
>> + compatible = "arm,coresight-dynamic-funnel",
>> "arm,primecell";
>> +
>> + reg = <0 0x06c2d000 0 0x1000>;
>> + reg-names = "funnel-base";
>> +
>> + clocks = <&aoss_qmp>;
>> + clock-names = "apb_pclk";
>> +
>> + out-ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + port {
>> + tpdm_mm_out_tpda9: endpoint {
>> + remote-endpoint = <&tpda_9_in_tpdm_mm>;
>> + };
>> + };
>> + };
>> +
>> + in-ports {
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> +
>> + port@2 {
>> + reg = <2>;
>> + funnel_dl_center_in_funnel_dl_mm: endpoint {
>> + remote-endpoint =
>> <&funnel_dl_mm_out_funnel_dl_center>;
>> + };
>> + };
>> + };
>> + };
>> +
>> etm@...0000 {
>> compatible = "arm,coresight-etm4x", "arm,primecell";
>> reg = <0 0x07040000 0 0x1000>;
Powered by blists - more mailing lists