linux-kernel - Re: [PATCHv12 8/9] serial: qcom_geni_serial: Disable MMIO tracing for geni serial

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 28 Apr 2022 12:50:19 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Sai Prakash Ranjan <quic_saipraka@...cinc.com>
Cc:     arnd@...db.de, catalin.marinas@....com, rostedt@...dmis.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
        maz@...nel.org, quic_psodagud@...cinc.com, quic_tsoni@...cinc.com,
        will@...nel.org, Bjorn Andersson <bjorn.andersson@...aro.org>
Subject: Re: [PATCHv12 8/9] serial: qcom_geni_serial: Disable MMIO tracing
 for geni serial

On Thu, Apr 28, 2022 at 03:25:31PM +0530, Sai Prakash Ranjan wrote:
> Disable MMIO tracing for geni serial driver as it is a high
> frequency operation for serial driver with many register reads/
> writes and not very useful to log all MMIO traces and prevent
> excessive logging.
> 
> Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> Signed-off-by: Sai Prakash Ranjan <quic_saipraka@...cinc.com>
> ---
>  drivers/tty/serial/qcom_geni_serial.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
> index 1543a6028856..5b48e6c2bf3c 100644
> --- a/drivers/tty/serial/qcom_geni_serial.c
> +++ b/drivers/tty/serial/qcom_geni_serial.c
> @@ -1,5 +1,11 @@
>  // SPDX-License-Identifier: GPL-2.0
> -// Copyright (c) 2017-2018, The Linux foundation. All rights reserved.
> +/*
> + * Copyright (c) 2017-2018, The Linux Foundation. All rights reserved.
> + * Copyright (c) 2022 Qualcomm Innovation Center, Inc. All rights reserved.
> + */

I strongly disagree that adding a single line here warrants a copyright
update.  If your lawyers will sign off on this change, I am willing to
reconsider.


> +
> +/* Disable MMIO tracing */

Please say why in the comment, not just what.

thanks,

greg k-h