linux-kernel - Re: [PATCH] nvmem: qfprom: using pm_runtime_resume_and_get instead of pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a6cc645-4e23-6ca0-b07e-37ff8660c1a7@linaro.org>
Date:   Fri, 29 Apr 2022 10:27:23 +0100
From:   Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:     cgel.zte@...il.com
Cc:     linux-kernel@...r.kernel.org, Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] nvmem: qfprom: using pm_runtime_resume_and_get instead of
 pm_runtime_get_sync



On 11/04/2022 02:40, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
> 
> Using pm_runtime_resume_and_get is more appropriate
> for simplifing code
> 
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>

Applied thanks,

--srini
> ---
>   drivers/nvmem/qfprom.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/nvmem/qfprom.c b/drivers/nvmem/qfprom.c
> index 162132c7dab9..c1e893c8a247 100644
> --- a/drivers/nvmem/qfprom.c
> +++ b/drivers/nvmem/qfprom.c
> @@ -217,9 +217,8 @@ static int qfprom_enable_fuse_blowing(const struct qfprom_priv *priv,
>   		goto err_clk_rate_set;
>   	}
>   
> -	ret = pm_runtime_get_sync(priv->dev);
> +	ret = pm_runtime_resume_and_get(priv->dev);
>   	if (ret < 0) {
> -		pm_runtime_put_noidle(priv->dev);
>   		dev_err(priv->dev, "Failed to enable power-domain\n");
>   		goto err_reg_enable;
>   	}