linux-kernel - Re: [PATCH] EDAC/ghes: change ghes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YmuvX8APTbzCNqRQ@zn.tnic>
Date:   Fri, 29 Apr 2022 11:26:55 +0200
From:   Borislav Petkov <bp@...en8.de>
To:     Tom Rix <trix@...hat.com>
Cc:     mchehab@...nel.org, tony.luck@...el.com, james.morse@....com,
        rric@...nel.org, linux-edac@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] EDAC/ghes: change ghes_hw from global to static

On Thu, Apr 21, 2022 at 09:53:19AM -0400, Tom Rix wrote:
> Smatch reports this issue
> ghes_edac.c:44:3: warning: symbol 'ghes_hw' was not declared. Should it be static?
> 
> ghes_hw is only used in ghes_edac.c so change its
> storage-class specifier to static.
> 
> Signed-off-by: Tom Rix <trix@...hat.com>
> ---
>  drivers/edac/ghes_edac.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/edac/ghes_edac.c b/drivers/edac/ghes_edac.c
> index 2805d5610300..59b0bedc9c24 100644
> --- a/drivers/edac/ghes_edac.c
> +++ b/drivers/edac/ghes_edac.c
> @@ -38,7 +38,7 @@ static struct ghes_pvt *ghes_pvt;
>   * This driver's representation of the system hardware, as collected
>   * from DMI.
>   */
> -struct ghes_hw_desc {
> +static struct ghes_hw_desc {
>  	int num_dimms;
>  	struct dimm_info *dimms;
>  } ghes_hw;
> -- 

Applied, thanks.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette