linux-kernel - Re: [PATCH V9 16/24] LoongArch: Add misc common routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-aac79f77-a392-42cd-a885-247e7625046c@palmer-mbp2014>
Date:   Sat, 30 Apr 2022 06:22:32 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     chenhuacai@...il.com, Arnd Bergmann <arnd@...db.de>,
        chenhuacai@...ngson.cn, luto@...nel.org, tglx@...utronix.de,
        peterz@...radead.org, akpm@...ux-foundation.org, airlied@...ux.ie,
        corbet@....net, Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-arch@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, lixuefeng@...ngson.cn,
        siyanteng@...ngson.cn, guoren@...nel.org, kernel@...0n.name,
        jiaxun.yang@...goat.com, guoren@...ux.alibaba.com
Subject:     Re: [PATCH V9 16/24] LoongArch: Add misc common routines

On Sat, 30 Apr 2022 03:41:59 PDT (-0700), Arnd Bergmann wrote:
> On Sat, Apr 30, 2022 at 12:00 PM Huacai Chen <chenhuacai@...il.com> wrote:
>>
>> On Sat, Apr 30, 2022 at 5:50 PM Arnd Bergmann <arnd@...db.de> wrote:
>> >
>> > On Sat, Apr 30, 2022 at 11:05 AM Huacai Chen <chenhuacai@...ngson.cn> wrote:
>> >
>> > > +unsigned long __xchg_small(volatile void *ptr, unsigned long val, unsigned int size)
>> > > +{
>> > > +       u32 old32, mask, temp;
>> > > +       volatile u32 *ptr32;
>> > > +       unsigned int shift;
>> > > +
>> > > +       /* Check that ptr is naturally aligned */
>> >
>> > As discussed, please remove this function and all the references to it.
>>
>> It seems that "generic ticket spinlock" hasn't been merged in 5.18?
>
> No, but we can merge it together with the loongarch architecture for 5.19.
>
> I suggested you coordinate with Guo Ren and Palmer Dabbelt about how
> to best merge it. The latest version was pasted two weeks ago [1], and
> it sounds like there are only minor issues to work out and that I can merge
> v4 into the asm-generic tree before merging the loongarch code in the
> same place.
>
>      Arnd
>
> [1] https://lore.kernel.org/lkml/20220414220214.24556-1-palmer@rivosinc.com/

I can just send another version, IIRC it was just that discussion about 
the memory barrier and there's already prototype code so it shouldn't be 
too bad.  I was hoping to do it sooner, sorry.