linux-kernel - Re: [PATCH V9 16/24] LoongArch: Add misc common routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAhV-H7zX+FdVLRuNDd6Nt4YJGumUsWgoJnEe4E3RuR+dXPraw@mail.gmail.com>
Date:   Sun, 1 May 2022 13:12:03 +0800
From:   Huacai Chen <chenhuacai@...il.com>
To:     Palmer Dabbelt <palmer@...belt.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Huacai Chen <chenhuacai@...ngson.cn>,
        Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        David Airlie <airlied@...ux.ie>,
        Jonathan Corbet <corbet@....net>,
        Linus Torvalds <torvalds@...ux-foundation.org>,
        linux-arch <linux-arch@...r.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Li Xuefeng <lixuefeng@...ngson.cn>,
        Yanteng Si <siyanteng@...ngson.cn>,
        Guo Ren <guoren@...nel.org>, WANG Xuerui <kernel@...0n.name>,
        Jiaxun Yang <jiaxun.yang@...goat.com>, guoren@...ux.alibaba.com
Subject: Re: [PATCH V9 16/24] LoongArch: Add misc common routines

Hi, Palmer,

On Sat, Apr 30, 2022 at 9:22 PM Palmer Dabbelt <palmer@...belt.com> wrote:
>
> On Sat, 30 Apr 2022 03:41:59 PDT (-0700), Arnd Bergmann wrote:
> > On Sat, Apr 30, 2022 at 12:00 PM Huacai Chen <chenhuacai@...il.com> wrote:
> >>
> >> On Sat, Apr 30, 2022 at 5:50 PM Arnd Bergmann <arnd@...db.de> wrote:
> >> >
> >> > On Sat, Apr 30, 2022 at 11:05 AM Huacai Chen <chenhuacai@...ngson.cn> wrote:
> >> >
> >> > > +unsigned long __xchg_small(volatile void *ptr, unsigned long val, unsigned int size)
> >> > > +{
> >> > > +       u32 old32, mask, temp;
> >> > > +       volatile u32 *ptr32;
> >> > > +       unsigned int shift;
> >> > > +
> >> > > +       /* Check that ptr is naturally aligned */
> >> >
> >> > As discussed, please remove this function and all the references to it.
> >>
> >> It seems that "generic ticket spinlock" hasn't been merged in 5.18?
> >
> > No, but we can merge it together with the loongarch architecture for 5.19.
> >
> > I suggested you coordinate with Guo Ren and Palmer Dabbelt about how
> > to best merge it. The latest version was pasted two weeks ago [1], and
> > it sounds like there are only minor issues to work out and that I can merge
> > v4 into the asm-generic tree before merging the loongarch code in the
> > same place.
> >
> >      Arnd
> >
> > [1] https://lore.kernel.org/lkml/20220414220214.24556-1-palmer@rivosinc.com/
>
> I can just send another version, IIRC it was just that discussion about
> the memory barrier and there's already prototype code so it shouldn't be
> too bad.  I was hoping to do it sooner, sorry.
I've seen your v4 patches, then I will adjust LoongArch code to use
generic ticket spinlocks.

Huacai