linux-kernel - Re: [PATCH 1/2] MIPS: IP27: Remove incorrect `cpu_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2204301607380.9383@angie.orcam.me.uk>
Date:   Sat, 30 Apr 2022 16:09:24 +0100 (BST)
From:   "Maciej W. Rozycki" <macro@...am.me.uk>
To:     Stephen Zhang <starzhangzsd@...il.com>
cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Joshua Kinard <kumba@...too.org>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 1/2] MIPS: IP27: Remove incorrect `cpu_has_fpu'
 override

On Sat, 30 Apr 2022, Stephen Zhang wrote:

> > Remove unsupported forcing of `cpu_has_fpu' to 1, which makes the `nofpu'
> > kernel parameter non-functional, and also causes a link error:
> >
> > ld: arch/mips/kernel/traps.o: in function `trap_init':
> > ./arch/mips/include/asm/msa.h:(.init.text+0x348): undefined reference to `handle_fpe'
> > ld: ./arch/mips/include/asm/msa.h:(.init.text+0x354): undefined reference to `handle_fpe'
> > ld: ./arch/mips/include/asm/msa.h:(.init.text+0x360): undefined reference to `handle_fpe'
> >
> > where the CONFIG_MIPS_FP_SUPPORT configuration option has been chosen.
> >
> 
> Sorry, but I have a question. From the code in
> arch/mips/kernel/genex.S:567, 'handle_fpe’‘s
>  definition is controlled by CONFIG_MIPS_FP_SUPPORT. Then how can it
> still report such
> error when the CONFIG_MIPS_FP_SUPPORT configuration option has been chosen.

 Good catch, thanks!  For some reason I inverted the condition in my mind 
as I wrote the change description.  I have now posted v2 with the mistake 
corrected.

  Maciej