linux-kernel - Re: [PATCH 1/2] MIPS: IP27: Remove incorrect `cpu_has

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANubcdU99rke6AM4bQEyPNTkJbk1kMit1UVyDggTwTciTUeQMA@mail.gmail.com>
Date:   Sat, 30 Apr 2022 13:34:08 +0800
From:   Stephen Zhang <starzhangzsd@...il.com>
To:     "Maciej W. Rozycki" <macro@...am.me.uk>
Cc:     Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Joshua Kinard <kumba@...too.org>, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH 1/2] MIPS: IP27: Remove incorrect `cpu_has_fpu' override

Maciej W. Rozycki <macro@...am.me.uk> 于2022年4月29日周五 22:57写道：
>
> Remove unsupported forcing of `cpu_has_fpu' to 1, which makes the `nofpu'
> kernel parameter non-functional, and also causes a link error:
>
> ld: arch/mips/kernel/traps.o: in function `trap_init':
> ./arch/mips/include/asm/msa.h:(.init.text+0x348): undefined reference to `handle_fpe'
> ld: ./arch/mips/include/asm/msa.h:(.init.text+0x354): undefined reference to `handle_fpe'
> ld: ./arch/mips/include/asm/msa.h:(.init.text+0x360): undefined reference to `handle_fpe'
>
> where the CONFIG_MIPS_FP_SUPPORT configuration option has been chosen.
>

Sorry, but I have a question. From the code in
arch/mips/kernel/genex.S:567, 'handle_fpe’‘s
 definition is controlled by CONFIG_MIPS_FP_SUPPORT. Then how can it
still report such
error when the CONFIG_MIPS_FP_SUPPORT configuration option has been chosen.


Stephen.