linux-kernel - Re: [PATCH] mm: don't be stuck to rmap lock on reclaim path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YnHzvV2Uz2ynENnG@casper.infradead.org>
Date:   Wed, 4 May 2022 04:32:13 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Minchan Kim <minchan@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        linux-mm <linux-mm@...ck.org>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Michal Hocko <mhocko@...e.com>,
        John Dias <joaodias@...gle.com>,
        Tim Murray <timmurray@...gle.com>
Subject: Re: [PATCH] mm: don't be stuck to rmap lock on reclaim path

On Tue, May 03, 2022 at 10:03:41AM -0700, Minchan Kim wrote:
> -void rmap_walk(struct folio *folio, const struct rmap_walk_control *rwc);
> -void rmap_walk_locked(struct folio *folio, const struct rmap_walk_control *rwc);
> +void rmap_walk(struct folio *folio, struct rmap_walk_control *rwc);
> +void rmap_walk_locked(struct folio *folio, struct rmap_walk_control *rwc);

I see the build bot already beat me to pointing out why this is wrong,
but do you not look at git log to figure out why code was changed to be
the way it is now, before you change it back?