linux-kernel - RE: [PATCH] video: hyperv_fb: Allow resolutions with size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BYAPR21MB12702855D53B456E898ED5E0BFC39@BYAPR21MB1270.namprd21.prod.outlook.com>
Date:   Wed, 4 May 2022 17:05:05 +0000
From:   Dexuan Cui <decui@...rosoft.com>
To:     Haiyang Zhang <haiyangz@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>,
        Saurabh Sengar <ssengar@...ux.microsoft.com>,
        "Michael Kelley (LINUX)" <mikelley@...rosoft.com>
CC:     Saurabh Singh Sengar <ssengar@...rosoft.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "deller@....de" <deller@....de>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-fbdev@...r.kernel.org" <linux-fbdev@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] video: hyperv_fb: Allow resolutions with size > 64 MB for
 Gen1

> From: Haiyang Zhang <haiyangz@...rosoft.com>
> > > ...
> > > -	if (gen2vm) {
> > > -		pot_start = 0;
> > > -		pot_end = -1;
> > > -	} else {
> > > -		if (!(pci_resource_flags(pdev, 0) & IORESOURCE_MEM) ||
> > > -		    pci_resource_len(pdev, 0) < screen_fb_size) {
> > > -			pr_err("Resource not available or (0x%lx < 0x%lx)\n",
> > > -			       (unsigned long) pci_resource_len(pdev, 0),
> > > -			       (unsigned long) screen_fb_size);
> > > -			goto err1;
> >
> > This restriction has been in place since day 1. Haiyang, you wrote this
> > driver. Can you comment on whether this change here is sensible?
> 
> When I initially implemented this driver 10 years ago, I believe there
> was smaller limit for the fb... But I think this patch is good for the
> newer MMIO alloc scheme. I hope to see reviews also from
>  @Dexuan Cui @Michael Kelley (LINUX) who are more familiar with
> the PCI/BAR/MMIO area.
> 
> Thanks,
> - Haiyang

The patch looks good to me but I suggest we check with the Hyper-V
team to figure out how a Gen1 Windows VM supports a higher
resolution that needs a VRAM size of more than 64MB. Just in case we
miss something..

Thanks,
-- Dexuan