linux-kernel - Re: [PATCH 05/16] nvme: zns: Allow ZNS drives that have non-power_of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 4 May 2022 10:38:50 +0200
From:   Pankaj Raghav <p.raghav@...sung.com>
To:     Bart Van Assche <bvanassche@....org>, <jaegeuk@...nel.org>,
        <axboe@...nel.dk>, <snitzer@...nel.org>, <hch@....de>,
        <mcgrof@...nel.org>, <naohiro.aota@....com>, <sagi@...mberg.me>,
        <damien.lemoal@...nsource.wdc.com>, <dsterba@...e.com>,
        <johannes.thumshirn@....com>
CC:     <linux-kernel@...r.kernel.org>, <linux-btrfs@...r.kernel.org>,
        <clm@...com>, <gost.dev@...sung.com>, <chao@...nel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>, <josef@...icpanda.com>,
        <jonathan.derrick@...ux.dev>, <agk@...hat.com>,
        <kbusch@...nel.org>, <kch@...dia.com>,
        <linux-nvme@...ts.infradead.org>, <dm-devel@...hat.com>,
        <jiangbo.365@...edance.com>, <linux-fsdevel@...r.kernel.org>,
        <matias.bjorling@....com>, <linux-block@...r.kernel.org>
Subject: Re: [PATCH 05/16] nvme: zns: Allow ZNS drives that have
 non-power_of_2 zone size


On 2022-05-03 18:50, Bart Van Assche wrote:
> On 4/27/22 09:02, Pankaj Raghav wrote:
>> -    sector &= ~(ns->zsze - 1);
>> +    sector = rounddown(sector, ns->zsze);
> 
> The above change breaks 32-bit builds since ns->zsze is 64 bits wide and
> since rounddown() uses the C division operator instead of div64_u64().
> 
Good catch. I don't see any generic helper for rounddown that will work
for both 32 bits and 64 bits. Maybe I will open code the rounddown logic
here so that it works for both 32 and 64 bits.
> Thanks,
> 
> Bart.