linux-kernel - Re: [PATCH 15/16] f2fs: ensure only power of 2 zone sizes are allowed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <850340eb-fc88-38a7-4c92-1c389e92b0ad@samsung.com>
Date:   Wed, 4 May 2022 10:53:28 +0200
From:   Pankaj Raghav <p.raghav@...sung.com>
To:     Jaegeuk Kim <jaegeuk@...nel.org>
CC:     <axboe@...nel.dk>, <snitzer@...nel.org>, <hch@....de>,
        <mcgrof@...nel.org>, <naohiro.aota@....com>, <sagi@...mberg.me>,
        <damien.lemoal@...nsource.wdc.com>, <dsterba@...e.com>,
        <johannes.thumshirn@....com>, <linux-kernel@...r.kernel.org>,
        <linux-btrfs@...r.kernel.org>, <clm@...com>,
        <gost.dev@...sung.com>, <chao@...nel.org>,
        <linux-f2fs-devel@...ts.sourceforge.net>, <josef@...icpanda.com>,
        <jonathan.derrick@...ux.dev>, <agk@...hat.com>,
        <kbusch@...nel.org>, <kch@...dia.com>,
        <linux-nvme@...ts.infradead.org>, <dm-devel@...hat.com>,
        <bvanassche@....org>, <jiangbo.365@...edance.com>,
        <linux-fsdevel@...r.kernel.org>, <matias.bjorling@....com>,
        <linux-block@...r.kernel.org>
Subject: Re: [PATCH 15/16] f2fs: ensure only power of 2 zone sizes are
 allowed


On 2022-05-03 22:05, Jaegeuk Kim wrote:
> Applied to f2fs tree. Thanks,
>
Thanks Jaegeuk. I will remove the f2fs patches from my next revision

Regards,
Pankaj
> On 04/27, Pankaj Raghav wrote:
>> From: Luis Chamberlain <mcgrof@...nel.org>
>>
>> F2FS zoned support has power of 2 zone size assumption in many places
>> such as in __f2fs_issue_discard_zone, init_blkz_info. As the power of 2
>> requirement has been removed from the block layer, explicitly add a
>> condition in f2fs to allow only power of 2 zone size devices.
>>
>> This condition will be relaxed once those calculation based on power of
>> 2 is made generic.
>>
>> Signed-off-by: Luis Chamberlain <mcgrof@...nel.org>
>> Signed-off-by: Pankaj Raghav <p.raghav@...sung.com>
>> ---
>>  fs/f2fs/super.c | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
>> index f64761a15df7..db79abf30002 100644
>> --- a/fs/f2fs/super.c
>> +++ b/fs/f2fs/super.c
>> @@ -3685,6 +3685,10 @@ static int init_blkz_info(struct f2fs_sb_info *sbi, int devi)
>>  		return 0;
>>  
>>  	zone_sectors = bdev_zone_sectors(bdev);
>> +	if (!is_power_of_2(zone_sectors)) {
>> +		f2fs_err(sbi, "F2FS does not support non power of 2 zone sizes\n");
>> +		return -EINVAL;
>> +	}
>>  
>>  	if (sbi->blocks_per_blkz && sbi->blocks_per_blkz !=
>>  				SECTOR_TO_BLOCK(zone_sectors))
>> -- 
>> 2.25.1