linux-kernel - Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 5 May 2022 13:31:11 +0800
From:   Miles Chen <miles.chen@...iatek.com>
To:     <robh@...nel.org>
CC:     <allen-kh.cheng@...iatek.com>,
        <angelogioacchino.delregno@...labora.com>,
        <chun-jie.chen@...iatek.com>, <devicetree@...r.kernel.org>,
        <ikjn@...omium.org>, <krzk+dt@...nel.org>,
        <krzysztof.kozlowski+dt@...aro.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-clk@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-mediatek@...ts.infradead.org>, <matthias.bgg@...il.com>,
        <matthias.bgg@...nel.org>, <miles.chen@...iatek.com>,
        <mturquette@...libre.com>, <sboyd@...nel.org>
Subject: Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock

Hi Rob,

>> From: Matthias Brugger <matthias.bgg@...il.com>
>> 
>> The msdc gate is part of the MMC driver. Delete the binding description
>> of this node.
> 
>An ABI break is okay because ...?

Sorry for that, 

If the mediatek,mt8192-msdc part is removed from the driver, 
Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or 
we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.

e.g.,
          - mediatek,mt8192-msdc # deprecated


thanks,
Miles

> Signed-off-by: Matthias Brugger <matthias.bgg@...il.com>
> 
> ---
> 
> Changes in v2:
> - Delete compatible in binding descprition as well
> 
>  .../bindings/arm/mediatek/mediatek,mt8192-clock.yaml      | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> index c8c67c033f8c..b57cc2e69efb 100644
> --- a/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> +++ b/Documentation/devicetree/bindings/arm/mediatek/mediatek,mt8192-clock.yaml
> @@ -24,7 +24,6 @@ properties:
>            - mediatek,mt8192-imp_iic_wrap_w
>            - mediatek,mt8192-imp_iic_wrap_n
>            - mediatek,mt8192-msdc_top
> -          - mediatek,mt8192-msdc
>            - mediatek,mt8192-mfgcfg
>            - mediatek,mt8192-imgsys
>            - mediatek,mt8192-imgsys2
> @@ -107,13 +106,6 @@ examples:
>          #clock-cells = <1>;
>      };
>  
> -  - |
> -    msdc: clock-controller@...60000 {
> -        compatible = "mediatek,mt8192-msdc";
> -        reg = <0x11f60000 0x1000>;
> -        #clock-cells = <1>;
> -    };
> -
>    - |
>      mfgcfg: clock-controller@...bf000 {
>          compatible = "mediatek,mt8192-mfgcfg";
> -- 
> 2.34.1
> 
>