linux-kernel - Re: [PATCH] x86/sgx: simplify the return expression of sgx_drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YnWhmNMHG4yE5qhX@kernel.org>
Date:   Sat, 7 May 2022 01:30:48 +0300
From:   Jarkko Sakkinen <jarkko@...nel.org>
To:     Dave Hansen <dave.hansen@...el.com>
Cc:     cgel.zte@...il.com, dave.hansen@...ux.intel.com,
        tglx@...utronix.de, linux-sgx@...r.kernel.org,
        linux-kernel@...r.kernel.org, Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] x86/sgx: simplify the return expression of sgx_drv_init()

On Thu, May 05, 2022 at 10:31:41AM -0700, Dave Hansen wrote:
> On 5/4/22 19:16, cgel.zte@...il.com wrote:
> > From: Minghao Chi <chi.minghao@....com.cn>
> > 
> > Simplify the return expression.
> > 
> > Reported-by: Zeal Robot <zealci@....com.cn>
> > Signed-off-by: Minghao Chi <chi.minghao@....com.cn>
> 
> Folks, I'd really encourage you to spend your time elsewhere.  These
> "cleanup" or "simplify" patches as a whole have high rates of bugs.  I
> don't trust them.  Plus, they don't really make the code easier to
> understand.

I agree. I get this kind of clean up in the context of doing something
to the functionality (in the same path) but it does not live by its own.

Plus, these type of patches add to the effort backporting fixes.

BR, Jarkko