lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 6 May 2022 10:53:39 +0200 From: Guido Günther <guido.gunther@...i.sm> To: Liu Ying <victor.liu@....com> Cc: linux-phy@...ts.infradead.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org, kishon@...com, vkoul@...nel.org, robh@...nel.org, krzk@...nel.org, andrzej.hajda@...el.com, narmstrong@...libre.com, robert.foss@...aro.org, Laurent.pinchart@...asonboard.com, jonas@...boo.se, jernej.skrabec@...il.com, airlied@...ux.ie, daniel@...ll.ch, shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de, festevam@...il.com, linux-imx@....com, robert.chiras@....com, martin.kepplinger@...i.sm Subject: Re: [PATCH resend v8 1/5] drm/bridge: nwl-dsi: Set PHY mode in nwl_dsi_mode_set() Hi Liu, On Fri, Apr 29, 2022 at 08:30:43PM +0800, Liu Ying wrote: > Hi, > > On Fri, 2022-04-22 at 19:24 +0200, Guido Günther wrote: > > Hi, > > On Tue, Apr 19, 2022 at 09:08:48AM +0800, Liu Ying wrote: > > > The Northwest Logic MIPI DSI host controller embedded in i.MX8qxp > > > works with a Mixel MIPI DPHY + LVDS PHY combo to support either > > > a MIPI DSI display or a LVDS display. So, this patch calls > > > phy_set_mode() from nwl_dsi_mode_set() to set PHY mode to MIPI DPHY > > > explicitly. > > > > > > Cc: Guido Günther <agx@...xcpu.org> > > > Cc: Robert Chiras <robert.chiras@....com> > > > Cc: Martin Kepplinger <martin.kepplinger@...i.sm> > > > Cc: Andrzej Hajda <andrzej.hajda@...el.com> > > > Cc: Neil Armstrong <narmstrong@...libre.com> > > > Cc: Laurent Pinchart <Laurent.pinchart@...asonboard.com> > > > Cc: Jonas Karlman <jonas@...boo.se> > > > Cc: Jernej Skrabec <jernej.skrabec@...il.com> > > > Cc: David Airlie <airlied@...ux.ie> > > > Cc: Daniel Vetter <daniel@...ll.ch> > > > Cc: NXP Linux Team <linux-imx@....com> > > > Signed-off-by: Liu Ying <victor.liu@....com> > > Hope this patch won't fall through the cracks. > Can someone please apply it to drm-misc-next? Robert? Applied to drm-misc-next. Cheers, -- Guido > > Thanks, > Liu Ying > > > > --- > > > v7->v8: > > > * Resend with Andrzej's and Jernej's mail addressed updated. > > > > > > v6->v7: > > > * No change. > > > > > > v5->v6: > > > * Rebase the series upon v5.17-rc1. > > > * Set PHY mode in ->mode_set() instead of ->pre_enable() in the > > > nwl-dsi > > > bridge driver due to the rebase. > > > * Drop Guido's R-b tag due to the rebase. > > > > > > v4->v5: > > > * No change. > > > > > > v3->v4: > > > * No change. > > > > > > v2->v3: > > > * No change. > > > > > > v1->v2: > > > * Add Guido's R-b tag. > > > > > > drivers/gpu/drm/bridge/nwl-dsi.c | 6 ++++++ > > > 1 file changed, 6 insertions(+) > > > > > > diff --git a/drivers/gpu/drm/bridge/nwl-dsi.c > > > b/drivers/gpu/drm/bridge/nwl-dsi.c > > > index d5945501a5ee..85bab7372af1 100644 > > > --- a/drivers/gpu/drm/bridge/nwl-dsi.c > > > +++ b/drivers/gpu/drm/bridge/nwl-dsi.c > > > @@ -666,6 +666,12 @@ static int nwl_dsi_mode_set(struct nwl_dsi > > > *dsi) > > > return ret; > > > } > > > > > > + ret = phy_set_mode(dsi->phy, PHY_MODE_MIPI_DPHY); > > > + if (ret < 0) { > > > + DRM_DEV_ERROR(dev, "Failed to set DSI phy mode: %d\n", > > > ret); > > > + goto uninit_phy; > > > + } > > > + > > > ret = phy_configure(dsi->phy, phy_cfg); > > > if (ret < 0) { > > > DRM_DEV_ERROR(dev, "Failed to configure DSI phy: %d\n", > > > ret); > > > > I can't currently test this but it still looks good so > > > > Reviewed-by: Guido Günther <agx@...xcpu.org> > > > > Cheers, > > -- Guido > > > > > -- > > > 2.25.1 > > > >
Powered by blists - more mailing lists