linux-kernel - Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding of mt8192 clock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YnmXX0DldjhmbjY3@robh.at.kernel.org>
Date:   Mon, 9 May 2022 17:36:15 -0500
From:   Rob Herring <robh@...nel.org>
To:     Miles Chen <miles.chen@...iatek.com>
Cc:     allen-kh.cheng@...iatek.com,
        angelogioacchino.delregno@...labora.com,
        chun-jie.chen@...iatek.com, devicetree@...r.kernel.org,
        ikjn@...omium.org, krzk+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org,
        linux-arm-kernel@...ts.infradead.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
        matthias.bgg@...il.com, matthias.bgg@...nel.org,
        mturquette@...libre.com, sboyd@...nel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: ARM: Mediatek: Remove msdc binding
 of mt8192 clock

On Thu, May 05, 2022 at 01:31:11PM +0800, Miles Chen wrote:
> Hi Rob,
> 
> >> From: Matthias Brugger <matthias.bgg@...il.com>
> >> 
> >> The msdc gate is part of the MMC driver. Delete the binding description
> >> of this node.
> > 
> >An ABI break is okay because ...?
> 
> Sorry for that, 
> 
> If the mediatek,mt8192-msdc part is removed from the driver, 

That's an ABI break too. You just need to explain why as Matthias did in 
the commit message if the ABI break is okay.

> Is it ok to keep "mediatek,mt8192-msdc" in the binding document? or 
> we should add '# deprecated' to "mediatek,mt8192-msdc" and keep the example.

We do that sometimes, but depends on the situation.

Rob