linux-kernel - Re: [PATCH] iio: adc: fix return error variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 9 May 2022 09:34:57 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     <cgel.zte@...il.com>, <jic23@...nel.org>, <lars@...afoo.de>
CC:     <anand.ashok.dumbre@...inx.com>, <michal.simek@...inx.com>,
        <manish.narani@...inx.com>, <linux-iio@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, Lv Ruyi <lv.ruyi@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] iio: adc: fix return error variable



On 5/9/22 09:24, cgel.zte@...il.com wrote:
> From: Lv Ruyi <lv.ruyi@....com.cn>
> 
> Return irq instead of ret which always equals to zero here.
> 
> Fixes: d5c70627a794 ("iio: adc: Add Xilinx AMS driver")
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@....com.cn>
> ---
>   drivers/iio/adc/xilinx-ams.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/xilinx-ams.c b/drivers/iio/adc/xilinx-ams.c
> index a55396c1f8b2..a7687706012d 100644
> --- a/drivers/iio/adc/xilinx-ams.c
> +++ b/drivers/iio/adc/xilinx-ams.c
> @@ -1409,7 +1409,7 @@ static int ams_probe(struct platform_device *pdev)
>   
>   	irq = platform_get_irq(pdev, 0);
>   	if (irq < 0)
> -		return ret;
> +		return irq;
>   
>   	ret = devm_request_irq(&pdev->dev, irq, &ams_irq, 0, "ams-irq",
>   			       indio_dev);

Reviewed-by: Michal Simek <michal.simek@....com>

Thanks,
Michal