linux-kernel - Re: [PATCH] kernel/drivers: Remove redundant driver match function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hr153makg.wl-tiwai@suse.de>
Date:   Mon, 09 May 2022 09:25:51 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
Cc:     lizhe <sensor1010@....com>, lee.jones@...aro.org,
        fthain@...ux-m68k.org, akrowiak@...ux.ibm.com, pasic@...ux.ibm.com,
        jjherne@...ux.ibm.com, freude@...ux.ibm.com, hca@...ux.ibm.com,
        gor@...ux.ibm.com, agordeev@...ux.ibm.com,
        borntraeger@...ux.ibm.com, svens@...ux.ibm.com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, zbr@...emap.net, perex@...ex.cz,
        tiwai@...e.com, bvanassche@....org, dan.j.williams@...el.com,
        srinivas.kandagatla@...aro.org, wens@...e.org,
        colin.king@...el.com, hare@...e.de, linux-kernel@...r.kernel.org,
        linux-m68k@...ts.linux-m68k.org, linux-s390@...r.kernel.org,
        linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
        alsa-devel@...a-project.org
Subject: Re: [PATCH] kernel/drivers: Remove redundant driver match function

On Fri, 06 May 2022 08:49:27 +0200,
Uwe Kleine-König wrote:
> 
> Hello,
> 
> On Thu, May 05, 2022 at 09:59:52PM -0700, lizhe wrote:
> > If there is no driver match function, the driver core assumes that each
> > candidate pair (driver, device) matches, see driver_match_device().
> > 
> > Signed-off-by: lizhe <sensor1010@....com>
> 
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig.org>
> 
> Side note: While looking through this patch I was surprised to see there
> are two different busses for ac97: sound/ac97/bus.c + sound/ac97_bus.c .
> It seems the duplication exists since 2017.

Those are intentional and will be likely kept as-is.  In theory those
could be unified, but there are quite lots of quirk codes for the old
bus implementations and it'll be way too much work to rewrite for the
new bus.


Takashi