[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f5ca7c72-6526-d733-93fd-933aa9b719bc@wanyeetech.com>
Date: Mon, 9 May 2022 17:12:11 +0800
From: 周琰杰 <zhouyanjie@...yeetech.com>
To: Aidan MacDonald <aidanmacdonald.0x0@...il.com>, sboyd@...nel.org,
mturquette@...libre.com, tsbogend@...ha.franken.de
Cc: paulburton@...nel.org, paul@...pouillou.net,
linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-clk@...r.kernel.org
Subject: Re: [PATCH v2 0/3] Clock fixes for Ingenic SoCs
Hi,
On 2022/4/29 上午12:44, Aidan MacDonald wrote:
> I ran across a problem trying to get Linux running on an Ingenic X1000 SoC:
> since the memory clock isn't referenced by any driver, it appears unused and
> gets disabled automatically. After that, the system hangs on any RAM access.
>
> There is a hack in board-ingenic.c to forcibly enable the CPU clock, but this
> is insufficient for the X1000 since the memory clock has its own gate and mux
> that isn't tied to the CPU.
>
> This patch series fixes the bug by adding CLK_IS_CRITICAL flags to important
> clocks, which seems to be the approach used in many other SoC clock drivers.
>
> v2: Add comments to patch 02 to explain why we need CLK_IS_CRITICAL.
>
> Aidan MacDonald (3):
> clk: ingenic: Allow specifying common clock flags
> clk: ingenic: Mark critical clocks in Ingenic SoCs
> mips: ingenic: Do not manually reference the CPU clock
>
> arch/mips/generic/board-ingenic.c | 26 --------------------------
> drivers/clk/ingenic/cgu.c | 2 +-
> drivers/clk/ingenic/cgu.h | 3 +++
> drivers/clk/ingenic/jz4725b-cgu.c | 10 ++++++++++
> drivers/clk/ingenic/jz4740-cgu.c | 10 ++++++++++
> drivers/clk/ingenic/jz4760-cgu.c | 10 ++++++++++
> drivers/clk/ingenic/jz4770-cgu.c | 5 +++++
> drivers/clk/ingenic/jz4780-cgu.c | 15 +++++++++++++++
> drivers/clk/ingenic/x1000-cgu.c | 15 +++++++++++++++
> drivers/clk/ingenic/x1830-cgu.c | 11 +++++++++++
> 10 files changed, 80 insertions(+), 27 deletions(-)
Tested-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@...yeetech.com> # On X1000 and
X1830
Powered by blists - more mailing lists