linux-kernel - RE: [PATCH 2/3] tty: n_gsm: fix mux activation issues in gsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB9PR10MB588149B7E9A31D3476762776E0C69@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>
Date:   Mon, 9 May 2022 11:03:05 +0000
From:   "Starke, Daniel" <daniel.starke@...mens.com>
To:     Jiri Slaby <jirislaby@...nel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/3] tty: n_gsm: fix mux activation issues in gsm_config()

> >   static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c)
> >   {
> > +	int ret = 0;
> 
> Why is the initialization needed? You can as well declare the variable only inside the if below.

You are right, this was unneeded. But this patch was already included in
the tty-linus branch. Shall I resubmit it nevertheless?

Best regards,
Daniel Starke