linux-kernel - Re: [PATCH 2/3] tty: n_gsm: fix mux activation issues in gsm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b42bc4d1-cc9d-d115-c981-aaa053bdc59f@kernel.org>
Date:   Mon, 9 May 2022 13:13:19 +0200
From:   Jiri Slaby <jirislaby@...nel.org>
To:     "Starke, Daniel" <daniel.starke@...mens.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/3] tty: n_gsm: fix mux activation issues in gsm_config()

On 09. 05. 22, 13:03, Starke, Daniel wrote:
>>>    static int gsm_config(struct gsm_mux *gsm, struct gsm_config *c)
>>>    {
>>> +	int ret = 0;
>>
>> Why is the initialization needed? You can as well declare the variable only inside the if below.
> 
> You are right, this was unneeded. But this patch was already included in
> the tty-linus branch. Shall I resubmit it nevertheless?

In that case, you can only send a fixup patch...

thanks,
-- 
js
suse labs