linux-kernel - RE: [PATCH 3/3] tty: n_gsm: fix invalid gsmtty_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <DB9PR10MB58815BA44641534DAA6646B6E0C69@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>
Date:   Mon, 9 May 2022 11:10:15 +0000
From:   "Starke, Daniel" <daniel.starke@...mens.com>
To:     Jiri Slaby <jirislaby@...nel.org>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/3] tty: n_gsm: fix invalid gsmtty_write_room() result

> > +#define TX_SIZE		4096    /* Must be power of 2. */
> 
> Only that I'd not put the macro definition here. But outside the structure.
> 
> >   	struct kfifo fifo;	/* Queue fifo for the DLCI */

I have placed it at the field which it affects the same way as the original
author placed TX_THRESH_HI and TX_THRESH_LO at tx_list within struct gsm_mux.
I can resubmit this patch, but it was already included in the tty-linux
branch. Please let me know your opinion on this.

Best regards,
Daniel Starke