linux-kernel - Re: [PATCH V4 3/5] arm64: dts: nuvoton: Add initial support for MA35D1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 May 2022 16:50:17 +0800
From:   Jacky Huang <ychuang3@...oton.com>
To:     Arnd Bergmann <arnd@...db.de>
CC:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        DTML <devicetree@...r.kernel.org>,
        linux-clk <linux-clk@...r.kernel.org>,
        "Linux ARM" <linux-arm-kernel@...ts.infradead.org>,
        <ychuang570808@...il.com>, "Rob Herring" <robh+dt@...nel.org>,
        Stephen Boyd <sboyd@...nel.org>,
        "Krzysztof Kozlowski" <krzk+dt@...nel.org>,
        Olof Johansson <olof@...om.net>,
        "Catalin Marinas" <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, SoC Team <soc@...nel.org>,
        <cfli0@...oton.com>
Subject: Re: [PATCH V4 3/5] arm64: dts: nuvoton: Add initial support for
 MA35D1



On 2022/5/10 下午 03:01, Arnd Bergmann wrote:
> On Tue, May 10, 2022 at 5:25 AM Jacky Huang <ychuang3@...oton.com> wrote:
>> Add the initial device tree files for Nuvoton MA35D1 Soc.
>>
>> Signed-off-by: Jacky Huang <ychuang3@...oton.com>
>> ---
>> +
>> +/ {
>> +       model = "Nuvoton MA35D1-EVB";
>> +       compatible = "nuvoton,ma35d1-evb", "nuvoton,ma35d1";
>> +
>> +       chosen {
>> +               stdout-path = "serial0:115200n8";
>> +       };
> Something seems to be missing here: you set the console to the serial0
> alias, but that is not defined anywhere, and the ma35d1.dtsi file does not
> appear to define any UART at all. Are you still missing the driver for this?
>
> Please add a more detailed description in the changelog text above that
> explains what kind of SoC this is (maybe a link to the product web page,
> if there is one), and a status of how complete the support is: which drivers
> are already merged, and which ones are still being worked on?
>
>          Arnd

Hi Arnd,

The serial driver is ready 
(https://github.com/OpenNuvoton/MA35D1_linux-5.4.y/blob/master/drivers/tty/serial/ma35d1_serial.c),
but we have to review the coding style and porting it from Linux 5.4.y 
to 5.18.

In the next patch version, I will added a brief introduction about 
MA35D1 in the cover-letter [PATCH 0/5].

Thanks for your review.

Sincerely,
Jacky Huang