linux-kernel - RE: [PATCH 3/7] tty: xilinx_uartps: Add check for runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR02MB6635C3E7DEBAAA146D3DF440AAC99@DM6PR02MB6635.namprd02.prod.outlook.com>
Date:   Tue, 10 May 2022 11:53:36 +0000
From:   Shubhrajyoti Datta <shubhraj@...inx.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        Michal Simek <michals@...inx.com>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        git <git@...inx.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 3/7] tty: xilinx_uartps: Add check for runtime_get_sync
 calls



> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Friday, May 6, 2022 2:21 AM
> To: Shubhrajyoti Datta <shubhraj@...inx.com>
> Cc: linux-serial@...r.kernel.org; Michal Simek <michals@...inx.com>;
> jirislaby@...nel.org; git <git@...inx.com>; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 3/7] tty: xilinx_uartps: Add check for runtime_get_sync calls
> 
> On Fri, Apr 29, 2022 at 01:44:18PM +0530, Shubhrajyoti Datta wrote:
> > Add a check for the return value of runtime get_sync calls.
> >
> > Addresses-Coverity: Event check_return.
> > Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
> > ---
> >  drivers/tty/serial/xilinx_uartps.c | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/xilinx_uartps.c
> > b/drivers/tty/serial/xilinx_uartps.c
> > index 8f15fe24a0eb..868f4e587263 100644
> > --- a/drivers/tty/serial/xilinx_uartps.c
> > +++ b/drivers/tty/serial/xilinx_uartps.c
> > @@ -1100,13 +1100,17 @@ static void cdns_uart_poll_put_char(struct
> > uart_port *port, unsigned char c)  static void cdns_uart_pm(struct uart_port
> *port, unsigned int state,
> >  		   unsigned int oldstate)
> >  {
> > +	int ret;
> > +
> >  	switch (state) {
> >  	case UART_PM_STATE_OFF:
> >  		pm_runtime_mark_last_busy(port->dev);
> >  		pm_runtime_put_autosuspend(port->dev);
> >  		break;
> >  	default:
> > -		pm_runtime_get_sync(port->dev);
> > +		ret = pm_runtime_get_sync(port->dev);
> > +		if (ret < 0)
> > +			dev_err(port->dev, "Failed to enable clocks\n");
> 
> So you just ignore the error?  SHouldn't you propagate it back upward?

The cdns_uart_pm is void so we cannot propagate it upward.

> 
> thanks,
> 
> greg k-h