linux-kernel - RE: [PATCH 0/7] tty: xilinx_uartps: fixes and improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 10 May 2022 11:54:18 +0000
From:   Shubhrajyoti Datta <shubhraj@...inx.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        Michal Simek <michals@...inx.com>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        git <git@...inx.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 0/7] tty: xilinx_uartps: fixes and improvements

Hi Greg,

Thanks for the review.

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Friday, May 6, 2022 2:19 AM
> To: Shubhrajyoti Datta <shubhraj@...inx.com>
> Cc: linux-serial@...r.kernel.org; Michal Simek <michals@...inx.com>;
> jirislaby@...nel.org; git <git@...inx.com>; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 0/7] tty: xilinx_uartps: fixes and improvements
> 
> On Fri, Apr 29, 2022 at 01:44:15PM +0530, Shubhrajyoti Datta wrote:
> > Many of the stuff is reported by static analysis changes are
> >
> > - Update the copyright text
> > - Check the return valuesof runtime and clock enable calls
> > - Check the ignore_status in the isr
> > - Prevent writing to the fifo when controller is disabled.
> >
> > Michal Simek (1):
> >   xilinx: Update copyright text to correct format
> >
> > Shubhrajyoti Datta (6):
> >   tty: xilinx_uartps: Check the clk_enable return value
> >   tty: xilinx_uartps: Add check for runtime_get_sync calls
> >   tty: xilinx_uartps: Check clk_enable return type
> >   tty: xilinx_uartps: Make the timeout unsigned
> >   serial: uartps: Fix the ignore_status
> >   serial: uartps: Prevent writes when the controller is disabled
> 
> Nit, why is the subject line prefix not unified here?  Shouldn't they all be "tty:
> xilinx_uartps:" like 4 of them are?
> 
> Can you fix up and resend?

I will fix up and resend in v2
> 
> thanks,
> 
> greg k-h