linux-kernel - RE: [PATCH 2/7] tty: xilinx_uartps: Check the clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <BY5PR12MB49028F76B4701BA309913A6181969@BY5PR12MB4902.namprd12.prod.outlook.com>
Date:   Thu, 28 Jul 2022 11:09:10 +0000
From:   "Datta, Shubhrajyoti" <shubhrajyoti.datta@....com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
CC:     "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "git@...inx.com" <git@...inx.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value

[AMD Official Use Only - General]

Hi Greg,

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Friday, May 6, 2022 2:20 AM
> To: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
> Cc: linux-serial@...r.kernel.org; michal.simek@...inx.com;
> jirislaby@...nel.org; git@...inx.com; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value
> 
> On Fri, Apr 29, 2022 at 01:44:17PM +0530, Shubhrajyoti Datta wrote:
> > Check the clk_enable return value.
> 
> That says what, but not why.
> 
Will fix v2.
> >
> > Addresses-Coverity: Event check_return.
> 
> Shouldn't this be a covertity id?

I could not find the warning in the Coverity that is run on the linux kernel. 
Somehow was seeing int when I was running  locally.

> 
> thanks,
> 
> greg k-h