linux-kernel - Re: [PATCH 2/7] tty: xilinx_uartps: Check the clk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 28 Jul 2022 13:48:44 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     "Datta, Shubhrajyoti" <shubhrajyoti.datta@....com>
Cc:     Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "michal.simek@...inx.com" <michal.simek@...inx.com>,
        "jirislaby@...nel.org" <jirislaby@...nel.org>,
        "git@...inx.com" <git@...inx.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value

On Thu, Jul 28, 2022 at 11:09:10AM +0000, Datta, Shubhrajyoti wrote:
> [AMD Official Use Only - General]
> 
> Hi Greg,
> 
> > -----Original Message-----
> > From: Greg KH <gregkh@...uxfoundation.org>
> > Sent: Friday, May 6, 2022 2:20 AM
> > To: Shubhrajyoti Datta <shubhrajyoti.datta@...inx.com>
> > Cc: linux-serial@...r.kernel.org; michal.simek@...inx.com;
> > jirislaby@...nel.org; git@...inx.com; linux-kernel@...r.kernel.org
> > Subject: Re: [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value
> > 
> > On Fri, Apr 29, 2022 at 01:44:17PM +0530, Shubhrajyoti Datta wrote:
> > > Check the clk_enable return value.
> > 
> > That says what, but not why.
> > 
> Will fix v2.
> > >
> > > Addresses-Coverity: Event check_return.
> > 
> > Shouldn't this be a covertity id?
> 
> I could not find the warning in the Coverity that is run on the linux kernel. 
> Somehow was seeing int when I was running  locally.

Ok, then there's no need to reference coverity at all then :)

thanks,

greg k-h