linux-kernel - Re: [next] sh: hugetlb.h:27:1: error: no return statement in function returning non-void [-Werror=return-type]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YnwCZMldIQiQUrKt@casper.infradead.org>
Date:   Wed, 11 May 2022 19:37:24 +0100
From:   Matthew Wilcox <willy@...radead.org>
To:     Naresh Kamboju <naresh.kamboju@...aro.org>,
        Baolin Wang <baolin.wang@...ux.alibaba.com>
Cc:     Linux-Next Mailing List <linux-next@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        linux-mm <linux-mm@...ck.org>, lkft-triage@...ts.linaro.org,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Peter Xu <peterx@...hat.com>,
        Alistair Popple <apopple@...dia.com>,
        Andrea Arcangeli <aarcange@...hat.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        David Hildenbrand <david@...hat.com>,
        Hugh Dickins <hughd@...gle.com>,
        Jerome Glisse <jglisse@...hat.com>,
        "Kirill A . Shutemov" <kirill@...temov.name>,
        Mike Kravetz <mike.kravetz@...cle.com>,
        Mike Rapoport <rppt@...ux.vnet.ibm.com>,
        Nadav Amit <nadav.amit@...il.com>,
        Arnd Bergmann <arnd@...db.de>
Subject: Re: [next] sh: hugetlb.h:27:1: error: no return statement in
 function returning non-void [-Werror=return-type]

On Wed, May 11, 2022 at 09:26:45PM +0530, Naresh Kamboju wrote:
> arch/sh/include/asm/hugetlb.h: In function 'huge_ptep_clear_flush':
> arch/sh/include/asm/hugetlb.h:27:1: error: no return statement in
> function returning non-void [-Werror=return-type]
>    27 | }
>       | ^
> cc1: some warnings being treated as errors

It's easy enough to figure out whose patch this was.

$ git log -p next-20220511 arch/sh/include/asm/hugetlb.h

commit 083af99303b9
Author: Baolin Wang <baolin.wang@...ux.alibaba.com>
Date:   Tue May 10 17:47:33 2022 -0700

    mm: change huge_ptep_clear_flush() to return the original pte

You don't have to spray everybody who's ever touched the MM with email.