linux-kernel - Re: [PATCH] tpm: sleep at least <...> ms in tpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e3ce7c535e27369c07500064dc25c2fc8e7b3f86.camel@HansenPartnership.com>
Date:   Wed, 11 May 2022 16:12:18 -0400
From:   James Bottomley <James.Bottomley@...senPartnership.com>
To:     Johannes Holland <johannes.holland@...ineon.com>,
        jarkko@...nel.org, linux-integrity@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     peterhuewe@....de, jgg@...pe.ca
Subject: Re: [PATCH] tpm: sleep at least <...> ms in tpm_msleep()

On Tue, 2022-05-10 at 13:29 +0200, Johannes Holland wrote:
> To comply with protocol requirements, minimum polling times must
> often be adhered to. Therefore, a macro like tpm_msleep() should
> sleep at least the given amount of time (not up to the given period).
> Have tpm_msleep() sleep at least the given number of milliseconds.
> 
> Signed-off-by: Johannes Holland <johannes.holland@...ineon.com>

This seems to fix the problem I reported years ago with my Nuvoton
laptop TPM.

https://lore.kernel.org/linux-integrity/1531328689.3260.8.camel@HansenPartnership.com/

It probably needs to soak a bit longer to declare victory (this timeout
failure is very intermittent), but it looks hopeful.

Regards,

James