linux-kernel - Re: [PATCH 2/7] x86/entry: Move PTI_USER_* to arch/x86/include/asm/processor-flags.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 11 May 2022 20:40:38 +0800
From:   Lai Jiangshan <jiangshanlai@...il.com>
To:     Thomas Gleixner <tglx@...utronix.de>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Borislav Petkov <bp@...en8.de>,
        Peter Zijlstra <peterz@...radead.org>,
        Josh Poimboeuf <jpoimboe@...hat.com>,
        Andy Lutomirski <luto@...nel.org>, X86 ML <x86@...nel.org>,
        Lai Jiangshan <jiangshan.ljs@...group.com>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Andrew Morton <akpm@...ux-foundation.org>,
        "Aneesh Kumar K.V" <aneesh.kumar@...ux.ibm.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>,
        Pasha Tatashin <pasha.tatashin@...een.com>
Subject: Re: [PATCH 2/7] x86/entry: Move PTI_USER_* to arch/x86/include/asm/processor-flags.h

On Wed, May 11, 2022 at 6:25 PM Thomas Gleixner <tglx@...utronix.de> wrote:
>
> On Wed, May 11 2022 at 15:27, Lai Jiangshan wrote:
> > From: Lai Jiangshan <jiangshan.ljs@...group.com>
> >
> > These constants will be also used in C file.
> >
> > Move them to arch/x86/include/asm/processor-flags.h which already has
> > a kin X86_CR3_PTI_PCID_USER_BIT defined in it.
> >
> > Remove PTI_PGTABLE_SWITCH_BIT and replace it with PTI_USER_PGTABLE_BIT
> > since they are the same in meaning and value.
>
> Just from looking at the patch it's obvious that it breaks the 32bit
> CONFIG_PAGETABLE_ISOLATION=y build. Sigh.

Ahhh.
Thank you!

I'm sorry and I will move the "#ifdef CONFIG_X86_64" down a
little bit in arch/x86/include/asm/processor-flags.h.

Thanks
Lai