linux-kernel - Re: [PATCH] usb: hub: Simplify error and success path in port_over_current

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 12 May 2022 17:44:31 +0200
From:   Eugeniu Rosca <erosca@...adit-jv.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Eugeniu Rosca <erosca@...adit-jv.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Rajat Jain <rajatja@...gle.com>, Andrew Lunn <andrew@...n.ch>,
        Chris Chiu <chris.chiu@...onical.com>,
        Marek Szyprowski <m.szyprowski@...sung.com>,
        <linux-usb@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Naveen kumar Sunkari <naveenkumar.sunkari@...bosch.com>,
        Bhuvanesh Surachari <Bhuvanesh_Surachari@...tor.com>,
        Eugeniu Rosca <rosca.eugeniu@...il.com>
Subject: Re: [PATCH] usb: hub: Simplify error and success path in
 port_over_current_notify

Dear Greg,

On Do, Mai 12, 2022 at 01:38:36 +0200, Greg Kroah-Hartman wrote:
> On Thu, May 12, 2022 at 01:15:27PM +0200, Eugeniu Rosca wrote:
> > From: Bhuvanesh Surachari <Bhuvanesh_Surachari@...tor.com>

[..]

> >  	if (!envp[1])
> > -		goto exit;
> > +		goto exit_path;
> 
> No need to rename this, right?
> 
> >  
> > -	envp[2] = NULL;
> >  	kobject_uevent_env(&hub_dev->kobj, KOBJ_CHANGE, envp);
> >  
> > +exit_path:
> >  	kfree(envp[1]);
> > -exit:
> 
> Move this up one line?

Thank you for your comments. Much appreciated.

Please, find the updated version at:
https://lore.kernel.org/linux-usb/1652369834-4480-1-git-send-email-erosca@de.adit-jv.com

Best regards,
Eugeniu