linux-kernel - Re: [PATCH 3/5] tty/termbits: remove #ifdef IBSHIFT that is always defined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yn4EXQisXkK9w0cs@hovoldconsulting.com>
Date:   Fri, 13 May 2022 09:10:21 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     linux-serial@...r.kernel.org, Greg KH <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] tty/termbits: remove #ifdef IBSHIFT that is always
 defined

On Wed, May 11, 2022 at 01:11:37PM +0300, Ilpo Järvinen wrote:
> IBSHIFT is defined by all architectures.

This also changed recently so mention the commit in question.

Subject is overly verbose here too.

> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
>  drivers/tty/tty_baudrate.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/drivers/tty/tty_baudrate.c b/drivers/tty/tty_baudrate.c
> index 07bbbfee5635..d10318956c97 100644
> --- a/drivers/tty/tty_baudrate.c
> +++ b/drivers/tty/tty_baudrate.c

> @@ -194,12 +187,10 @@ void tty_termios_encode_baud_rate(struct ktermios *termios,
>  			 */
>  			if (ofound == i && !ibinput)
>  				ifound  = i;
> -#ifdef IBSHIFT
>  			else {
>  				ifound = i;
>  				termios->c_cflag |= (baud_bits[i] << IBSHIFT);
>  			}
> -#endif

Please add the missing brackets to the if branch when removing the ifdef.

Johan