linux-kernel - Re: [PATCH 4/5] serial: fsl_lpuart: Remove unnecessary clearing for CRTSCTS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yn4Em6VtV9rwWjnT@hovoldconsulting.com>
Date:   Fri, 13 May 2022 09:11:23 +0200
From:   Johan Hovold <johan@...nel.org>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc:     linux-serial@...r.kernel.org, Greg KH <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/5] serial: fsl_lpuart: Remove unnecessary clearing for
 CRTSCTS

On Wed, May 11, 2022 at 01:11:38PM +0300, Ilpo Järvinen wrote:
> if (termios->c_cflag & CRTSCTS) guarantees that CRTSCTS is not ever set
> in the else block so clearing it is unnecessary.
> 
> While at it, remove also one pair of extra parenthesis.
> 
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>

Reviewed-by: Johan Hovold <johan@...nel.org>