linux-kernel - Re: [PATCH v4 1/5] dt-bindings: proximity: vl53l0x: Document optional supply and GPIO properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 14 May 2022 15:29:40 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Markuss Broks <markuss.broks@...il.com>,
        linux-kernel@...r.kernel.org,
        ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
        Konrad Dybcio <konrad.dybcio@...ainline.org>,
        Marijn Suijten <marijn.suijten@...ainline.org>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...ainline.org>,
        Song Qiang <songqiang1304521@...il.com>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>, linux-iio@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org
Subject: Re: [PATCH v4 1/5] dt-bindings: proximity: vl53l0x: Document
 optional supply and GPIO properties

On Fri, 13 May 2022 10:56:50 +0200
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org> wrote:

> On 12/05/2022 21:13, Markuss Broks wrote:
> > This patch adds the optional properties for the VL53L0X ToF sensor to the
> > device-tree binding.
> > 
> > Signed-off-by: Markuss Broks <markuss.broks@...il.com>  
> 
> Wait, two days and three versions? Please give some time before
> resending entire patchset.

Yeah, several instances of this on the IIO list this week. Please
let things sit for at least a few days between versions even if
the requested changes are fairly minor.

> 
> Same comments apply as for v2 and v3...
>
I 'could' fix this up, but given you've not responded to Krzysztof
I think I'd prefer you send a v5 in the second half of next week or
later (to give time for other review) with the patch description
change Krzysztof suggested made.

Code wise the series looks fine to me.

Jonathan



> 
> Best regards,
> Krzysztof