linux-kernel - Re: [PATCH] random: do not pretend to handle premature next security model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YoDTKTxrCXnIxDyJ@zx2c4.com>
Date:   Sun, 15 May 2022 12:17:13 +0200
From:   "Jason A. Donenfeld" <Jason@...c4.com>
To:     Eric Biggers <ebiggers@...nel.org>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH] random: do not pretend to handle premature next security
 model

Hi Eric,

On Sat, May 14, 2022 at 05:45:16PM -0700, Eric Biggers wrote:
> On Wed, May 11, 2022 at 12:32:19PM +0200, Jason A. Donenfeld wrote:
> > Hi Eric,
> > 
> > On Wed, May 11, 2022 at 01:09:13AM -0700, Eric Biggers wrote:
> > > A couple very minor comments:
> > 
> > Thanks, will fix these.
> > 
> > Jason
> 
> Found one more:
> 
>  /*
>   * Return whether the crng seed is considered to be sufficiently
>   * old that a reseeding might be attempted.
> 
> It should say "that a reseeding is needed", or something similar.

Ahh, since it's now unconditional. Nice catch. Fixed as you suggested.

Jason