linux-kernel - Re: [PATCH] random: do not pretend to handle premature next security model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YoBNHEqeNahziJt5@sol.localdomain>
Date:   Sat, 14 May 2022 17:45:16 -0700
From:   Eric Biggers <ebiggers@...nel.org>
To:     "Jason A. Donenfeld" <Jason@...c4.com>
Cc:     linux-crypto@...r.kernel.org, linux-kernel@...r.kernel.org,
        Theodore Ts'o <tytso@....edu>
Subject: Re: [PATCH] random: do not pretend to handle premature next security
 model

On Wed, May 11, 2022 at 12:32:19PM +0200, Jason A. Donenfeld wrote:
> Hi Eric,
> 
> On Wed, May 11, 2022 at 01:09:13AM -0700, Eric Biggers wrote:
> > A couple very minor comments:
> 
> Thanks, will fix these.
> 
> Jason

Found one more:

 /*
  * Return whether the crng seed is considered to be sufficiently
  * old that a reseeding might be attempted.

It should say "that a reseeding is needed", or something similar.

- Eric