linux-kernel - Re: [RFC Patch net-next v2 1/9] net: dsa: microchip: ksz8795: update the port_cnt value in ksz_chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220516104039.akra6bloviak22qe@skbuf>
Date:   Mon, 16 May 2022 13:40:39 +0300
From:   Vladimir Oltean <olteanv@...il.com>
To:     Arun Ramadoss <arun.ramadoss@...rochip.com>
Cc:     linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        Russell King <linux@...linux.org.uk>,
        Woojung Huh <woojung.huh@...rochip.com>,
        UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S. Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Oleksij Rempel <linux@...pel-privat.de>,
        Marek Vasut <marex@...x.de>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>,
        Eric Dumazet <edumazet@...gle.com>
Subject: Re: [RFC Patch net-next v2 1/9] net: dsa: microchip: ksz8795: update
 the port_cnt value in ksz_chip_data

On Fri, May 13, 2022 at 03:52:11PM +0530, Arun Ramadoss wrote:
> The port_cnt value in the structure is not used in the switch_init.
> Instead it uses the fls(chip->cpu_port), this is due to one of port in
> the ksz8794 unavailable. The cpu_port for the 8794 is 0x10, fls(0x10) =
> 5, hence updating it directly in the ksz_chip_data structure in order to
> same with all the other switches in ksz8795.c and ksz9477.c files.
> 
> Signed-off-by: Arun Ramadoss <arun.ramadoss@...rochip.com>
> ---

Sounds like a straightforward transformation based on a valid observation.

Reviewed-by: Vladimir Oltean <olteanv@...il.com>

>  drivers/net/dsa/microchip/ksz8795.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/dsa/microchip/ksz8795.c b/drivers/net/dsa/microchip/ksz8795.c
> index f91deea9368e..83bcabf2dc54 100644
> --- a/drivers/net/dsa/microchip/ksz8795.c
> +++ b/drivers/net/dsa/microchip/ksz8795.c
> @@ -1607,6 +1607,7 @@ static const struct ksz_chip_data ksz8_switch_chips[] = {
>  		 * KSZ8794   0,1,2      4
>  		 * KSZ8795   0,1,2,3    4
>  		 * KSZ8765   0,1,2,3    4
> +		 * port_cnt is configured as 5, even though it is 4
>  		 */
>  		.chip_id = 0x8794,
>  		.dev_name = "KSZ8794",
> @@ -1614,7 +1615,7 @@ static const struct ksz_chip_data ksz8_switch_chips[] = {
>  		.num_alus = 0,
>  		.num_statics = 8,
>  		.cpu_ports = 0x10,	/* can be configured as cpu port */
> -		.port_cnt = 4,		/* total cpu and user ports */
> +		.port_cnt = 5,		/* total cpu and user ports */
>  		.ksz87xx_eee_link_erratum = true,
>  	},
>  	{
> @@ -1653,7 +1654,7 @@ static int ksz8_switch_init(struct ksz_device *dev)
>  			dev->num_vlans = chip->num_vlans;
>  			dev->num_alus = chip->num_alus;
>  			dev->num_statics = chip->num_statics;
> -			dev->port_cnt = fls(chip->cpu_ports);
> +			dev->port_cnt = chip->port_cnt;
>  			dev->cpu_port = fls(chip->cpu_ports) - 1;
>  			dev->phy_port_cnt = dev->port_cnt - 1;
>  			dev->cpu_ports = chip->cpu_ports;
> -- 
> 2.33.0
>