lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 16 May 2022 13:51:26 +0300 From: Vladimir Oltean <olteanv@...il.com> To: Arun Ramadoss <arun.ramadoss@...rochip.com> Cc: linux-kernel@...r.kernel.org, netdev@...r.kernel.org, Russell King <linux@...linux.org.uk>, Woojung Huh <woojung.huh@...rochip.com>, UNGLinuxDriver@...rochip.com, Andrew Lunn <andrew@...n.ch>, Vivien Didelot <vivien.didelot@...il.com>, Florian Fainelli <f.fainelli@...il.com>, "David S. Miller" <davem@...emloft.net>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Oleksij Rempel <linux@...pel-privat.de>, Marek Vasut <marex@...x.de>, Michael Grzeschik <m.grzeschik@...gutronix.de>, Eric Dumazet <edumazet@...gle.com> Subject: Re: [RFC Patch net-next v2 2/9] net: dsa: microchip: move ksz_chip_data to ksz_common On Fri, May 13, 2022 at 03:52:12PM +0530, Arun Ramadoss wrote: > This patch moves the ksz_chip_data in ksz8795 and ksz9477 to ksz_common. > At present, the dev->chip_id is iterated with the ksz_chip_data and then > copy its value to the ksz_dev structure. These values are declared as > constant. > Instead of copying the values and referencing it, this patch update the > dev->info to the ksz_chip_data based on the chip_id in the init > function. And also update the ksz_chip_data values for the LAN937x based > switches. > > Signed-off-by: Arun Ramadoss <arun.ramadoss@...rochip.com> > --- Thanks, this looks good. I see that dev->info is assigned in ksz_switch_register and I had to look to see whether there is any dev->info dereference from before the call to ksz_switch_register(), and it looks like we're ok. Reviewed-by: Vladimir Oltean <olteanv@...il.com>
Powered by blists - more mailing lists